Add option to apply wobble to make_map#21
Merged
Merged
Conversation
adrien-laposta
left a comment
adrien-laposta
left a comment
Collaborator
There was a problem hiding this comment.
Same comment as in the sotodlib PR: can we directly use a sotodlib routine to make maps ? Could be better to not duplicate code which makes everything harder to maintain. No need to do it in this PR, this is just for future reference
adrien-laposta
approved these changes
Jun 24, 2026
Collaborator
Author
|
The reason I didn't directly integrate wobble to mapmaking function is because it only works when all the dets belong to single wafer band. Also I think it might be cleaner to integraye wobble to pointing model, not pointing matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be merged after sotodlib PR is merged simonsobs/sotodlib#1675